fix: handle Windows backslash separators in isUnderMountPoint#7
Merged
mcollina merged 1 commit intoplatformatic:mainfrom Apr 20, 2026
Merged
Conversation
isUnderMountPoint hardcoded / as the path separator, so Windows paths produced by path.normalize (which uses \) never matched their mount point. Check for both / and \ after the mount-point prefix, and handle roots that already end with a separator (e.g. C:\ or /).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isUnderMountPointhardcodes/as the path separator. On Windows,normalizeVFSPathproduces backslashes viapath.normalize, so paths likeC:\foo\mount\file.jsnever match mount pointC:\foo\mount. This causesshouldHandleto returnfalseandreadFileSyncto throwENOENTfor every path under a Windows mount point.The fix checks for both
/and\at the mount point boundary instead of hardcoding/.